Public Access
Add Flooded pages across Minecraft versions and fix 1.21.1 workstations
Build and smoke / changes (push) Waiting to run
Build and smoke / changes (push) Waiting to run
This commit is contained in:
1 parent
4a59fb5d02
commit
441f2896d7
40 files changed
+1018
-64
No files matched your search
@@ -102,3 +102,12 @@ automated two-client pass. The test server was stopped, logs retained under
|
||||
build/verification/issue100-manual, and its temporary world removed.
|
||||
See [the final parity review](MC263_PARITY_REVIEW.md). Renderer bug #116 remains
|
||||
separately tracked. #103/#104 and parent #96 close after release verification.
|
||||
|
||||
## 2026-11-15 release update
|
||||
|
||||
The first Minecraft-prefixed 1.21.1 release is 1.21.1.0.3, collecting Mixer #105,
|
||||
Flat #106 and Flooded #107. The matching 26.3 release is 26.3.0.5 with Flooded and
|
||||
the Reborn acknowledgement guard. Both player checks passed; publication was
|
||||
explicitly authorized. Reborn is not crash-free: #118 remains open. #117 owns
|
||||
full Seamless support. #116 was user-closed as resolved. Prior dated evidence
|
||||
above remains historical; unchanged earlier artifacts are not relabeled.
|
||||
@@ -0,0 +1,98 @@
|
||||
# Flooded Pages (issue #107)
|
||||
|
||||
Available in releases 1.21.1.0.3 and 26.3.0.5. The player passed both game
|
||||
versions, with Reborn crashes separately tracked in
|
||||
[#118](https://git.paddedcell.org/dnorberg/rivencraft/issues/118).
|
||||
|
||||
## Writing
|
||||
|
||||
Flooded is an Environment Page in Creative and the page feed used by optional
|
||||
JEI. It reuses glyph composition, without a new bitmap.
|
||||
|
||||
Number Pages immediately before Flooded encode the absolute topmost water block
|
||||
Y as base-25 digits, most significant first.
|
||||
|
||||
| Number Pages before Flooded | Water block Y |
|
||||
| --- | --- |
|
||||
| None | 63 |
|
||||
| 0 | 0 |
|
||||
| 24 | 24 |
|
||||
| 2, 13 | 63 |
|
||||
| 2, 24 | 74 |
|
||||
| 4, 0 | 100 |
|
||||
|
||||
The visible surface is at Y+1. Only an adjacent number run applies; other pages
|
||||
break it. The last Flooded wins. An unnumbered final Flooded returns to Y=63.
|
||||
Duplicates follow ordinary singular-controller recovery and instability.
|
||||
Number chains are special to Flooded; color/celestial number behavior is unchanged.
|
||||
|
||||
Existing Number Pages are unsigned. Requested levels clamp between
|
||||
max(0, dimension minimum Y) and dimension maximum Y minus 5, leaving emergency
|
||||
platform/headroom space. Overflow saturates safely. There is no signed Number
|
||||
Page for a negative surface; open spaces below zero still flood.
|
||||
|
||||
## Generation and travel
|
||||
|
||||
Works with Cave, Standard, Amplified, Flat, Island and Void terrain.
|
||||
Without Flooded, Cave default fluid is air and water aquifers are disabled;
|
||||
separate authored fluid/lake features retain their own behavior.
|
||||
|
||||
Flooding runs after terrain, carvers and decorations. It fills air, preserves
|
||||
solid terrain/material features and roofs, and wets waterloggable blocks. A lower
|
||||
requested line drains ordinary water/aquatic plants above it and dries waterlogged
|
||||
solids without deleting them. It is generation, not a per-tick refill system.
|
||||
Neighbor features and normal fluid physics can still change blocks afterward.
|
||||
|
||||
The policy is frozen into generator state/ordered writing and survives codec
|
||||
reload. Worldgen does not consult mutable SavedData. Arrival searches reject
|
||||
submerged space. Fallback platforms rise above the water; no-platform travel may
|
||||
fail safely when natural footing is unavailable.
|
||||
|
||||
Existing generated chunks are not rewritten or retroactively drained. Existing
|
||||
saved arrival positions remain. Use new Ages for validation; mixed old/new chunks
|
||||
can retain different earlier layouts.
|
||||
|
||||
## Validation
|
||||
|
||||
1.21.1: three focused tests passed for ordered numbers, plan/generator codecs,
|
||||
two water levels in Cave-like in-memory chunks, dry Cave settings, solid/waterlogged
|
||||
block preservation and the public page feed.
|
||||
|
||||
26.3: 21 isolated dedicated checks passed for equivalent grammar/support/feed,
|
||||
two levels, block preservation/draining, codec and authored non-Cave biome, dry
|
||||
Cave defaults and safe-height bounds. The first probe exposed an adjacent-number
|
||||
grammar penalty; it was corrected before the passing run. No test stalled.
|
||||
|
||||
The port probe stays outside shipping sources and uses a disposable world/build:
|
||||
|
||||
python3 scripts/regression_flood263.py
|
||||
|
||||
Player checks on both versions:
|
||||
|
||||
1. A fresh Cave Age without Flooded stays free of default water flooding.
|
||||
2. Cave Ages using 24 + Flooded and 2 + 24 + Flooded stop at water block Y=24
|
||||
and Y=74 respectively.
|
||||
3. A Flat/Plains Age with Flooded uses the selected/default level and safe arrival.
|
||||
4. Return, save/reload, revisit, and check new chunks retain the same water level.
|
||||
Books/portals must not spawn the player underwater.
|
||||
5. Flooded appears in Environment Creative pages and JEI when installed.
|
||||
Optionally verify a large number chain clamps safely near the ceiling.
|
||||
|
||||
Both game versions are tested sequentially. Test logs remain under
|
||||
build/verification/flood107; temporary worlds and fixture outputs are removed.
|
||||
|
||||
## Reborn travel disconnect during player validation
|
||||
|
||||
The 26.3.0.4 client disconnected on a block-change acknowledgement after Age
|
||||
travel. Reborn 7.0.12 called getClientWorlds while its world map was uninitialized
|
||||
after dimension replacement. The integrated server stopped after the client left;
|
||||
the report was not a Flooded generator server exception.
|
||||
|
||||
26.3.0.5 adds a client-only compatibility guard: on the game thread, while Reborn's
|
||||
map is uninitialized, use vanilla acknowledgement handling for the packet
|
||||
listener's world. Initialized Reborn retains its normal multiworld handling.
|
||||
No networking payload format, 1.21.1 code or saved player data changed for this fix.
|
||||
Build and target-method signatures verified. The player accepted 26.3 Flooded,
|
||||
but subsequently encountered a different null-section rebuild crash while exploring.
|
||||
That renderer failure remains unresolved in #118; 26.3.0.5 is not advertised as
|
||||
crash-free with Reborn. Full Seamless support is tracked in #117.
|
||||
+11
-1
@@ -26,7 +26,7 @@ core tests when investigating an issue:
|
||||
```
|
||||
|
||||
Available suite names are `linking`, `environment`, `writing`, `grammar`,
|
||||
`generation`, `desk`, `binder`, `mixer`, `recipe`, and `instability`. The `generation` archive
|
||||
`generation`, `desk`, `binder`, `mixer`, `recipe`, `instability`, `flat`, and `flood`. The `generation` archive
|
||||
keeps the detailed feature, structure, ore, crystal, and fissure regressions
|
||||
out of the default smoke run. The `instability` archive adds multi-player loaded-chunk selection, policy gates, and protected-block checks without rerunning the default scoring and migration tests. Three checks formerly registered twice in the
|
||||
core and their archives now run only through the core wrapper. Run all
|
||||
@@ -175,3 +175,13 @@ server, so physical placement is handed to the player for in-game verification:
|
||||
Repeat
|
||||
with `gl` or `glo` to confirm names do not change page validity. An explicit
|
||||
Flat or Cave Terrain Page with Rocks should still be rejected.
|
||||
|
||||
|
||||
The `flat` archive covers issue #106 without loading dynamic Ages: Y=0 layer/height
|
||||
queries, authored-biome generator codec reload, zero-minimum dimension profiles,
|
||||
and unchanged empty Void columns. Travel/revisit/full-world restart remains a
|
||||
player check in a fresh Flat Age.
|
||||
|
||||
The flood archive covers #107 grammar/codecs and in-memory water filling.
|
||||
The 26.3 equivalent is scripts/regression_flood263.py. Run servers sequentially.
|
||||
See [Flooded Pages](FLOODED_PAGES.md) for the travel/reload player checklist.
|
||||
@@ -1,5 +1,10 @@
|
||||
# 26.3 port parity and acceptance review
|
||||
|
||||
Update 2026-11-15: Flooded passed on both versions (#107). #116 was later closed
|
||||
by the user as resolved; current Reborn crashes are separately tracked in #118.
|
||||
Full Seamless live views remain future work in #117. The dated port review below
|
||||
does not imply all subsequent third-party renderer bugs are fixed.
|
||||
|
||||
Reviewed 2026-11-14 for 26.3.0.3 against the independently maintained 1.21.1
|
||||
implementation. This closes the port feature checklist, not every open bug or
|
||||
future enhancement. The dated development entries in MINECRAFT_26_3_PORT.md
|
||||
|
||||
Reference in new issue
Block a user