Complete instability regression slice and ordered modifiers (#73)

docs/LIVE_BLOCK_INSTABILITY.md

@@ -1,4 +1,4 @@
-# Live block-instability profiling (0.5.8.11–0.5.8.15)
+# Live block-instability profiling (0.5.8.11–0.5.8.17)
 
 Mystcraft Legacy measures the abundance of watched blocks in generated chunks,
 compares that abundance with a baseline, and adds only positive excess to the
@@ -26,8 +26,24 @@ Legacy weights are used for its watched blocks: coal/lapis 5, iron 60, emerald
 50. Deepslate variants inherit their ore's weight. Modern/high-value extensions
 include diamond, emerald, gold, iron, raw gold, raw iron and netherite storage
 blocks, plus ancient debris. Netherite blocks cost 8,000 per excess block per
-sampled chunk; ancient debris costs 4,000. Modded blocks are not automatically
-classified as valuable; this avoids charging unknown decorative materials.
+sampled chunk; ancient debris costs 4,000.
+
+Other mods remain optional. When an installed mod registers common-tagged ores
+or storage blocks, recognizable `*_ore` blocks, or source-fluid blocks,
+Rivencraft automatically includes those blocks in live profiling. The source
+fluid weight is 1.25; common mineral names such as tin,
+lead, zinc, silver, uranium, platinum, and iridium have explicit tiers, while
+other tagged ores use 60 and other tagged storage blocks use 120. The optional
+`instability_modded_materials.block_weight_overrides` list accepts a full-block
+`modid:block_id=points` entry to cover a block without common tags or replace
+its inferred weight; zero excludes it. Block entities and non-source fluid
+plants are excluded. Rivencraft never requires any particular content mod.
+
+Profiles written before 0.5.8.17 did not retain all modded material
+counts, so their block sample data resets and is collected again after upgrade.
+The saved Age definition and authored score are not changed. Later config
+changes can rescore materials already captured in the profile; a newly added
+override for a block that was not previously recognized needs fresh samples.
 
 The authored score and provider plan remain saved as the Age's immutable base.
 Only Ages created with instability schema v2 participate; existing v1 Ages
@@ -72,5 +88,7 @@ Do not retry that stalled scenario automatically. In a disposable world:
    receive little or no ore contribution. Check that profiling does not make
    chunk loading noticeably stall, and report any exception or server hang.
 
-Do not use a valued save for this check. The game jar builds, but live chunk
-profiling still needs this player-run validation before issue #73 is closed.
+Do not use a valued save for this check. The player reported an in-game pass
+for the 0.5.8.18 candidate on 2026-10-12. The three detailed scenarios above
+remain useful for future regression runs; the report does not establish that
+each was exercised individually.

docs/MILESTONE_6_REGRESSION.md

@@ -27,6 +27,8 @@ handed to the player in [the block-profile checklist](LIVE_BLOCK_INSTABILITY.md)
 | Decay loaded-chunk target and spawn protection | `AgeDecayGameTests.targetMustRemainInChosenLoadedChunk`, `savedSpawnAndPlatformAreProtected` |
 | Explosion policy gates and protected blocks | `Milestone6RegressionGameTests.disabledGriefAndProtectedBlocksStayUntouched` |
 | No Overworld status or decay provider | `AgeStatusEffectGameTests.overworldCannotRunAnAgeStatusProvider`; `AgeDecayGameTests.overworldCannotRunDecayProvider` |
+| Optional-mod material weights, block overrides, and old profile migration | `Milestone6RegressionGameTests.commonModdedMaterialWeightsStayBounded`, `blockProfileSamplesPersistWithoutDoubleCounting` |
+| Ordered celestial modifier consumption, repeated modifiers, and dangling +100 per kind | `WritingGrammarGameTests.orderedGrammarAcceptsPartialWritingAndDiagnosesInvalidSequences`; `EnvironmentWritingGameTests.celestialModifiersFollowWrittenOrder` |
 
 These tests exercise saved-data serialization and deterministic policies. They
 do **not** simulate a complete process restart, an actual multiplayer server,
@@ -45,6 +47,9 @@ checks live only in the `instability` archive to avoid duplicating default tests
   That check is narrower than arbitrary missing biome, block, or worldgen
   registry entries: loading a world with removed data packs is not guaranteed.
   Broad save compatibility and migration remain tracked in #60.
+- Version-3 plans keep their previous stage-sorted celestial interpretation and
+  frozen writing cost. Only new version-4 plans consume period/phase modifiers
+  in authored order and charge a trailing modifier once per pending kind.
 - In-process roundtrips cannot prove that Age dimensions reload correctly
   after a full stop/start. Check that in a real client/server world. Do not add
   another GameTest for it if it hits the documented storage stall; hand the
@@ -81,6 +86,13 @@ entry from a valued world; copy the test save first.
    a disposable copy; confirm its Age season behavior and that Rivencraft
    itself still loads. JEI should display the relevant pages and recipes when
    installed, while the mod works without it.
+   Separately, install a mod with common-tagged ores/storage blocks or source
+   fluids. Compare a material-rich Age with an ordinary Age after the profile
+   thresholds are reached; the installed mod's recognized blocks should affect
+   the result without a Rivencraft allowlist. Then remove that optional mod in
+   a disposable copy and confirm Rivencraft still starts. Test a single
+   `block_weight_overrides` entry and a zero-weight exclusion. This remains a
+   player-run scenario, not an automated pass.
 5. Check the book preview separately with its fallback animation, Ponder/Create,
    and Immersive Portals when available. Opening a book should not change
    player location, instability diagnostics, or ambient audio in the actual
@@ -93,3 +105,54 @@ entry from a valued world; copy the test save first.
 
 The matrix is guidance for a player-run pass; none of these six scenarios is
 claimed as completed by the automated result above.
+The player reported an in-game pass for the 0.5.8.18 candidate on 2026-10-12.
+That is a release-slice acceptance report, not a claim that every expanded
+matrix row below was individually exercised.
+
+### Regression run record
+
+For each row, record pass/fail, world seed, Age name, Rivencraft version,
+optional-mod versions, and a short observation. "Not run" is intentional
+until a player completes the in-game check; a successful build is not a pass.
+
+| Area | Specific manual observation | Status |
+| --- | --- | --- |
+| New vs reused book | Dimension ID, score, and providers do not reroll | Not run |
+| Full process restart | Re-enter two Ages; saved traits, score, plan, and cooldowns persist | Not run |
+| Multiplayer isolation | Two Age players receive effects; Overworld player does not | Not run |
+| Loaded-chunk scope | Departing players permit unloading; hazards do not reach old chunks | Not run |
+| Controls | Global, per-Age, mutation, and provider toggles suppress effects without reroll | Not run |
+| Protected blocks | Explosion/decay/erosion spare arrival platforms, portals, and block entities | Not run |
+| Hazard visuals | Lightning, explosions, decay, status, burning, meteor, and erosion each behave when selected | Not run |
+| Third-party biomes | TerraBlender biome pages and cave classification survive Age creation/restart | Not run |
+| Optional integrations absent | Mod launches without JEI, Create/Ponder, Immersive Portals, Serene Seasons, or biome mods | Not run |
+| Optional integrations present | JEI pages/recipes, preview backends, seasonal behavior, and ambient sound work | Not run |
+| Optional-mod materials | Tagged ore/storage/source-fluid samples change live profile automatically | Not run |
+| Material overrides | Positive and zero `block_weight_overrides` values affect only named blocks | Not run |
+| Removed optional mod | Disposable copy launches without the mod; unknown sampled IDs stay serialized | Not run |
+| Removed symbol/handler | Frozen score and provider plan survive when nonessential data is removed | Not run |
+| Ordered modifiers | Five book-order cases below produce expected time and dangling costs | Not run |
+
+### Focused ordered-writing and optional-material checks for 0.5.8.18
+
+Use `/rivencraft age instability` in each newly bound Age; old Ages retain
+their original plan and score. Record each row as pass/fail with the Age name,
+world seed, installed optional mods, and the command output. The ordered
+modifier assertions are archived, not a claim that the stalled GameTest suite ran.
+
+| Book pages after Link Panel, in exact order | Expected result | Result |
+| --- | --- | --- |
+| Half Length, Double Length, Normal Time | Length combines to 1.25×, no dangling cost | Not run in game |
+| Normal Time, Zero Length | Sun keeps normal motion; one dangling +100 | Not run in game |
+| Rising, Normal Time, Setting | Rising start phase; Setting dangles +100 | Not run in game |
+| Half Length, Double Length, no celestial page | One combined pending length dangles +100; seeded clock remains | Not run in game |
+| Normal Time, Zero Length, Normal Time | Last sun consumes Zero Length; duplicate celestial cost remains separate | Not run in game |
+
+With a common-tagged ore/storage-block or source-fluid mod installed, bind
+comparable material-rich and ordinary Ages and wait for profiling thresholds.
+Verify the modded material contributes automatically, then restart and confirm
+the score/profile remains consistent. On a disposable copy, remove the mod and
+confirm Rivencraft launches without it; restore the mod before judging the
+world's registry-dependent terrain. Also check a zero-weight override and a
+positive override. These are optional-mod compatibility checks, not a new
+required dependency.