Cover panel-only book modifiers with regression test

src/main/java/net/dnorberg/rivencraft/gametest/BookBinderGameTests.java

@@ -6,6 +6,9 @@ import net.dnorberg.rivencraft.block.entity.BookBinderBlockEntity;
 import net.dnorberg.rivencraft.book.AgeReference;
 import net.dnorberg.rivencraft.book.AgeDimensionService;
 import net.dnorberg.rivencraft.book.AgeRegistrySavedData;
+import net.dnorberg.rivencraft.book.LinkProperties;
+import net.dnorberg.rivencraft.book.LinkTarget;
+import net.dnorberg.rivencraft.book.LinkingService;
 import net.dnorberg.rivencraft.item.PageItem;
 import net.dnorberg.rivencraft.menu.BookBinderMenu;
 import net.dnorberg.rivencraft.registry.ModBlocks;
@@ -17,6 +20,7 @@ import net.dnorberg.rivencraft.writing.SymbolReference;
 import net.dnorberg.rivencraft.writing.SymbolCatalog;
 import net.dnorberg.rivencraft.writing.WritingEntry;
 import net.minecraft.core.BlockPos;
+import net.minecraft.core.GlobalPos;
 import net.minecraft.gametest.framework.GameTest;
 import net.minecraft.gametest.framework.GameTestHelper;
 import net.minecraft.resources.ResourceLocation;
@@ -185,6 +189,50 @@ public final class BookBinderGameTests {
         helper.succeed();
     }
 
+    public static void panelOnlyBookRetainsApplicableModifiers(GameTestHelper helper) {
+        BookBinderBlockEntity binder = place(helper);
+        binder.setTitle("Modified Random Age");
+        binder.setItem(BookBinderBlockEntity.COVER, new ItemStack(Items.LEATHER));
+        ItemStack panel = PageItem.createLinkPanelPage();
+        panel.set(ModDataComponents.LINK_PROPERTIES.get(), new LinkProperties(
+                LinkProperties.DISARM | LinkProperties.MAINTAIN_MOMENTUM | LinkProperties.INTRA_LINKING));
+        var player = helper.makeMockServerPlayerInLevel();
+        player.moveTo(binder.getBlockPos().getX() + 0.5, binder.getBlockPos().getY() + 0.5,
+                binder.getBlockPos().getZ() + 0.5);
+        BookBinderMenu menu = new BookBinderMenu(1, player.getInventory(), binder);
+        menu.setCarried(panel);
+        helper.assertTrue(menu.clickMenuButton(player, BookBinderMenu.STRIP_CLICK_BASE),
+                "The link strip must accept the modified panel without symbol pages");
+        ItemStack result = menu.quickMoveStack(player, BookBinderMenu.RESULT);
+        helper.assertTrue(result.is(ModItems.DESCRIPTIVE_BOOK.get()),
+                "A Link Panel alone must create a random-Age Descriptive Book");
+        LinkProperties expected = new LinkProperties(LinkProperties.DISARM | LinkProperties.MAINTAIN_MOMENTUM);
+        helper.assertValueEqual(result.get(ModDataComponents.LINK_PROPERTIES.get()), expected,
+                "The panel-only book must keep travel modifiers but omit Intra Linking");
+        ItemStack restored = ItemStack.parseOptional(helper.getLevel().registryAccess(),
+                (net.minecraft.nbt.CompoundTag) result.saveOptional(helper.getLevel().registryAccess()));
+        helper.assertValueEqual(restored.get(ModDataComponents.LINK_PROPERTIES.get()), expected,
+                "Panel-only book modifiers must survive save and reload");
+        BlockPos departure = player.blockPosition();
+        BlockPos destination = departure.offset(3, 0, 0);
+        helper.getLevel().setBlock(destination.below(), Blocks.STONE.defaultBlockState(), 3);
+        helper.getLevel().setBlock(destination, Blocks.AIR.defaultBlockState(), 3);
+        helper.getLevel().setBlock(destination.above(), Blocks.AIR.defaultBlockState(), 3);
+        player.getInventory().setItem(4, new ItemStack(Items.DIAMOND, 3));
+        LinkTarget target = new LinkTarget(GlobalPos.of(helper.getLevel().dimension(), destination), 0.0F, 0.0F);
+        helper.assertValueEqual(LinkingService.travelWithFooting(player, target,
+                        restored.get(ModDataComponents.LINK_PROPERTIES.get()).forDescriptiveBook()),
+                LinkingService.LinkResult.SUCCESS,
+                "The panel-only book's properties must be accepted by grounded travel");
+        helper.assertTrue(player.getInventory().getItem(4).isEmpty(),
+                "Disarm must remove the carried items during panel-only book travel");
+        helper.assertTrue(helper.getLevel().getEntitiesOfClass(ItemEntity.class,
+                        new AABB(departure).inflate(5.0), entity -> entity.getItem().is(Items.DIAMOND))
+                        .stream().mapToInt(entity -> entity.getItem().getCount()).sum() >= 3,
+                "Disarm must drop the items at the departure location");
+        helper.succeed();
+    }
+
     @GameTest(template = "empty")
     public static void linkPanelOnlyCreatesCompletedRandomAgeBook(GameTestHelper helper) {
         BookBinderBlockEntity binder = place(helper);

src/main/java/net/dnorberg/rivencraft/gametest/CoreGameTests.java

@@ -87,6 +87,11 @@ public final class CoreGameTests {
         BookBinderGameTests.assemblyIsAtomicAndRetainsPageOrder(helper);
     }
 
+    @GameTest(template = "empty")
+    public static void panelOnlyBookModifiers(GameTestHelper helper) {
+        BookBinderGameTests.panelOnlyBookRetainsApplicableModifiers(helper);
+    }
+
     @GameTest(template = "empty")
     public static void binderRejectsConflictingGrammar(GameTestHelper helper) {
         BookBinderGameTests.conflictingGrammarKeepsBinderInputsRecoverable(helper);