From b8d26a90369df89cfda28fe36b42704e7166a3bd Mon Sep 17 00:00:00 2001 From: Dustin Norberg Date: Tue, 20 Oct 2026 17:12:21 -0400 Subject: [PATCH] Update optional JEI compatibility to 19.69.0.457 --- docs/MILESTONE_7_COMPATIBILITY_REVIEW.md | 2 +- docs/MILESTONE_7_JEI_REVIEW.md | 41 ++++++++++++++++++++++++ gradle.properties | 4 +-- 3 files changed, 44 insertions(+), 3 deletions(-) create mode 100644 docs/MILESTONE_7_JEI_REVIEW.md diff --git a/docs/MILESTONE_7_COMPATIBILITY_REVIEW.md b/docs/MILESTONE_7_COMPATIBILITY_REVIEW.md index f47c3be..f32849d 100644 --- a/docs/MILESTONE_7_COMPATIBILITY_REVIEW.md +++ b/docs/MILESTONE_7_COMPATIBILITY_REVIEW.md @@ -26,7 +26,7 @@ release V0.6.6.0. | --- | --- | --- | --- | | Dynamic Dimensions AR Edition (required) | 0.9.1 | 0.9.1 | No newer release found on [CurseForge](https://www.curseforge.com/minecraft/mc-mods/dynamicdimension-ar-edition/files/all). | | Bad Packets (required) | neo-0.8.2 | neo-0.8.2 | No newer matching [Modrinth](https://modrinth.com/mod/badpackets/versions) release found. | -| JEI (optional) | 19.57.0.449 | 19.64.0.455 | Separate update issue; verify recipe categories and GUI discovery. | +| JEI (optional) | 19.57.0.449 at #82 review | 19.69.0.457 beta | Updated in #86 after client and dedicated GameTest passes; see [JEI review](MILESTONE_7_JEI_REVIEW.md). | | Create (optional) | 6.0.10 | 6.0.10 | No newer matching [Modrinth](https://modrinth.com/mod/create/versions) release found. Its jar bundles Ponder 1.0.82. | | Ponder (bundled with Create) | 1.0.82 | 1.0.87 library artifact | [Maven](https://maven.createmod.net/net/createmod/ponder/ponder-neoforge/maven-metadata.xml) has a newer artifact, but Create 6.0.10 still bundles 1.0.82. Do not treat this as a separately installed Create update. | | Immersive Portals (optional) | 6.0.7 | 6.0.7 | No newer matching [Modrinth](https://modrinth.com/mod/immersive-portals-neoforge/versions) release found. | diff --git a/docs/MILESTONE_7_JEI_REVIEW.md b/docs/MILESTONE_7_JEI_REVIEW.md new file mode 100644 index 0000000..fb61091 --- /dev/null +++ b/docs/MILESTONE_7_JEI_REVIEW.md @@ -0,0 +1,41 @@ +# JEI compatibility review (#86) + +Reviewed 2026-10-20 for Minecraft 1.21.1 and NeoForge 21.1.264. Rivencraft +now targets JEI 19.69.0.457 after the client's in-game acceptance check. JEI +remains a `compileOnly` API and an opt-in +`localRuntime` dependency for development; the published mod has no required +JEI dependency. + +The [official 1.21.1 NeoForge files](https://www.curseforge.com/minecraft/mc-mods/jei/files/all?page=1&pageSize=20&version=1.21.1) +list 19.69.0.457 (beta, 2026-10-20) after 19.64.0.455 (release, 2026-10-16). +The [19.69.0.457 Modrinth changelog](https://modrinth.com/mod/jei/versions?g=1.21.1&l=neoforge) +has a published-jar bytecode compatibility check. Its preceding 19.69.0.456 +build changes ingredient search to Lucene and adds a runtime ingredient-search +refresh API. This makes page search a required client check, even though the +current Rivencraft plugin still compiles against the 457 API. The new Maven +runtime artifact is much larger (about 7 MB versus 2.3 MB for 455); a successful +compile alone is not evidence that its runtime plugin works. + +Checks performed before changing the pinned dependency: + +| Configuration | Result | +| --- | --- | +| `./gradlew -Pjei_version=19.69.0.457 -PwithJei=true build` | Passed; existing JEI API uses compile with four deprecation warnings and no errors. | +| `./gradlew -Pjei_version=19.69.0.457 -PwithJei=true runGameTestServer` | Passed; dedicated GameTest server loaded JEI 19.69.0.457 and all 74 required tests passed. | +| `./gradlew -Pjei_version=19.69.0.457 runGameTestServer` | Passed without JEI; all 74 required tests passed. | +| Prism client with JEI 19.69.0.457 and Rivencraft 0.6.6.6 | Client joined an integrated world; JEI registered Rivencraft extra ingredients and started without a JEI-plugin exception. The player reported an in-game pass for guide display, page search, and recipe visibility. | + +On first 457 launch, JEI migrated its old `lowMemorySlowSearchEnabled` config +key and saved a backup of the original `jei-client.ini`; that warning was +handled by JEI and did not block startup. No Rivencraft config was changed. + +The in-game acceptance report covers the visible JEI integration. A dedicated +GameTest server proves no server-side startup failure but does not exercise the +JEI GUI; keep page search, recipes, blank-Page hiding, and the Ink Mixer, +Writing Desk, and Book Binder guides in future upgrade checks. JEI is not +bundled into or required by the published Rivencraft jar. + +The final pinned `0.6.6.7` build passed. A repeat GameTest run from the pinned +configuration stalled during test-world preparation before running any cases; +it was stopped. The two successful pre-pin runs above used the same JEI version +and code, with the dependency supplied by a Gradle property override. diff --git a/gradle.properties b/gradle.properties index 3acf11e..e702110 100644 --- a/gradle.properties +++ b/gradle.properties @@ -22,7 +22,7 @@ neo_version=21.1.264 ponder_version=1.0.82 dynamic_dimensions_file_id=7707789 badpackets_version=0.8.2 -jei_version=19.57.0.449 +jei_version=19.69.0.457 # The loader version range can only use the major version of FML as bounds loader_version_range=[1,) @@ -36,7 +36,7 @@ mod_name=Rivencraft # The license of the mod. Review your options at https://choosealicense.com/. All Rights Reserved is the default. mod_license=LGPL-3.0-or-later # The mod version. Rivencraft uses the x.y.z.b policy documented in README.md. -mod_version=0.6.6.6 +mod_version=0.6.6.7 immersive_portals_version=6.0.7 terrablender_version=4.1.0.8 serene_seasons_version_id=B6nTjh4b