Public Access
99 lines
4.6 KiB
Markdown
99 lines
4.6 KiB
Markdown
# Flooded Pages (issue #107)
|
|
|
|
Available in releases 1.21.1.0.3 and 26.3.0.5. The player passed both game
|
|
versions, with Reborn crashes separately tracked in
|
|
[#118](https://git.paddedcell.org/dnorberg/rivencraft/issues/118).
|
|
|
|
## Writing
|
|
|
|
Flooded is an Environment Page in Creative and the page feed used by optional
|
|
JEI. It reuses glyph composition, without a new bitmap.
|
|
|
|
Number Pages immediately before Flooded encode the absolute topmost water block
|
|
Y as base-25 digits, most significant first.
|
|
|
|
| Number Pages before Flooded | Water block Y |
|
|
| --- | --- |
|
|
| None | 63 |
|
|
| 0 | 0 |
|
|
| 24 | 24 |
|
|
| 2, 13 | 63 |
|
|
| 2, 24 | 74 |
|
|
| 4, 0 | 100 |
|
|
|
|
The visible surface is at Y+1. Only an adjacent number run applies; other pages
|
|
break it. The last Flooded wins. An unnumbered final Flooded returns to Y=63.
|
|
Duplicates follow ordinary singular-controller recovery and instability.
|
|
Number chains are special to Flooded; color/celestial number behavior is unchanged.
|
|
|
|
Existing Number Pages are unsigned. Requested levels clamp between
|
|
max(0, dimension minimum Y) and dimension maximum Y minus 5, leaving emergency
|
|
platform/headroom space. Overflow saturates safely. There is no signed Number
|
|
Page for a negative surface; open spaces below zero still flood.
|
|
|
|
## Generation and travel
|
|
|
|
Works with Cave, Standard, Amplified, Flat, Island and Void terrain.
|
|
Without Flooded, Cave default fluid is air and water aquifers are disabled;
|
|
separate authored fluid/lake features retain their own behavior.
|
|
|
|
Flooding runs after terrain, carvers and decorations. It fills air, preserves
|
|
solid terrain/material features and roofs, and wets waterloggable blocks. A lower
|
|
requested line drains ordinary water/aquatic plants above it and dries waterlogged
|
|
solids without deleting them. It is generation, not a per-tick refill system.
|
|
Neighbor features and normal fluid physics can still change blocks afterward.
|
|
|
|
The policy is frozen into generator state/ordered writing and survives codec
|
|
reload. Worldgen does not consult mutable SavedData. Arrival searches reject
|
|
submerged space. Fallback platforms rise above the water; no-platform travel may
|
|
fail safely when natural footing is unavailable.
|
|
|
|
Existing generated chunks are not rewritten or retroactively drained. Existing
|
|
saved arrival positions remain. Use new Ages for validation; mixed old/new chunks
|
|
can retain different earlier layouts.
|
|
|
|
## Validation
|
|
|
|
1.21.1: three focused tests passed for ordered numbers, plan/generator codecs,
|
|
two water levels in Cave-like in-memory chunks, dry Cave settings, solid/waterlogged
|
|
block preservation and the public page feed.
|
|
|
|
26.3: 21 isolated dedicated checks passed for equivalent grammar/support/feed,
|
|
two levels, block preservation/draining, codec and authored non-Cave biome, dry
|
|
Cave defaults and safe-height bounds. The first probe exposed an adjacent-number
|
|
grammar penalty; it was corrected before the passing run. No test stalled.
|
|
|
|
The port probe stays outside shipping sources and uses a disposable world/build:
|
|
|
|
python3 scripts/regression_flood263.py
|
|
|
|
Player checks on both versions:
|
|
|
|
1. A fresh Cave Age without Flooded stays free of default water flooding.
|
|
2. Cave Ages using 24 + Flooded and 2 + 24 + Flooded stop at water block Y=24
|
|
and Y=74 respectively.
|
|
3. A Flat/Plains Age with Flooded uses the selected/default level and safe arrival.
|
|
4. Return, save/reload, revisit, and check new chunks retain the same water level.
|
|
Books/portals must not spawn the player underwater.
|
|
5. Flooded appears in Environment Creative pages and JEI when installed.
|
|
Optionally verify a large number chain clamps safely near the ceiling.
|
|
|
|
Both game versions are tested sequentially. Test logs remain under
|
|
build/verification/flood107; temporary worlds and fixture outputs are removed.
|
|
|
|
## Reborn travel disconnect during player validation
|
|
|
|
The 26.3.0.4 client disconnected on a block-change acknowledgement after Age
|
|
travel. Reborn 7.0.12 called getClientWorlds while its world map was uninitialized
|
|
after dimension replacement. The integrated server stopped after the client left;
|
|
the report was not a Flooded generator server exception.
|
|
|
|
26.3.0.5 adds a client-only compatibility guard: on the game thread, while Reborn's
|
|
map is uninitialized, use vanilla acknowledgement handling for the packet
|
|
listener's world. Initialized Reborn retains its normal multiworld handling.
|
|
No networking payload format, 1.21.1 code or saved player data changed for this fix.
|
|
Build and target-method signatures verified. The player accepted 26.3 Flooded,
|
|
but subsequently encountered a different null-section rebuild crash while exploring.
|
|
That renderer failure remains unresolved in #118; 26.3.0.5 is not advertised as
|
|
crash-free with Reborn. Full Seamless support is tracked in #117.
|